Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set a fixed agent name for the template type addon #413

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Apr 10, 2024

Summary

Related issue(s)

Fixes #387

Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7
Copy link
Member Author

/cc @qiujian16 @skeeey

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.46%. Comparing base (bcbe4d2) to head (69ae1d2).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   61.54%   62.46%   +0.91%     
==========================================
  Files         133      133              
  Lines       14078    11307    -2771     
==========================================
- Hits         8665     7063    -1602     
+ Misses       4664     3495    -1169     
  Partials      749      749              
Flag Coverage Δ
unit 62.46% <100.00%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 917539a into open-cluster-management-io:main Apr 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not contain a random string in the AddOn CSR common name
2 participants